Issue 1086813005: Wrap object observe implementation in a function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1086813005: Wrap object observe implementation in a function. (Closed)

Created:
5 years, 8 months ago by Yang

Modified:
5 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Wrap object observe implementation in a function. R=jkummerow@chromium.org Committed: https://crrev.com/c6a36305c726f0ff26a8b10c804a01834d5d5daf Cr-Commit-Position: refs/heads/master@{#27920}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -52 lines)			Patch
M	src/array.js	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	src/object-observe.js	View	32 chunks	+95 lines, -20 lines	0 comments	Download
M	src/v8natives.js	View	4 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086813005/1

5 years, 8 months ago (2015-04-17 13:46:55 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-17 14:10:16 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c6a36305c726f0ff26a8b10c804a01834d5d5daf
Cr-Commit-Position: refs/heads/master@{#27920}