Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1086813004: X87: Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations" (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations" port 8098253562c7585405f435145e7acf74ff0123f8 (r27898) original commit message: BUG= Committed: https://crrev.com/548a0b3bbdac37a4334e0df1a397d1b0b5a9e091 Cr-Commit-Position: refs/heads/master@{#27906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 8 months ago (2015-04-17 05:17:30 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-17 07:51:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086813004/1
5 years, 8 months ago (2015-04-17 07:51:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 08:18:19 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 08:18:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/548a0b3bbdac37a4334e0df1a397d1b0b5a9e091
Cr-Commit-Position: refs/heads/master@{#27906}

Powered by Google App Engine
This is Rietveld 408576698