Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 10868116: Pass result of blockage across content API when new tab blocked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.h ('k') | chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h » ('j') | ui/web_dialogs/web_dialog_web_contents_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/extensions/shell_window.cc
===================================================================
--- chrome/browser/ui/extensions/shell_window.cc (revision 154307)
+++ chrome/browser/ui/extensions/shell_window.cc (working copy)
@@ -215,7 +215,7 @@
return new_tab;
}
-void ShellWindow::AddNewContents(WebContents* source,
+bool ShellWindow::AddNewContents(WebContents* source,
WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
@@ -228,8 +228,8 @@
// new window.
disposition =
disposition == NEW_BACKGROUND_TAB ? disposition : NEW_FOREGROUND_TAB;
- chrome::AddWebContents(browser, NULL, new_contents, disposition, initial_pos,
- user_gesture);
+ return chrome::AddWebContents(
+ browser, NULL, new_contents, disposition, initial_pos, user_gesture);
}
void ShellWindow::HandleKeyboardEvent(
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.h ('k') | chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h » ('j') | ui/web_dialogs/web_dialog_web_contents_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698