Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6593)

Unified Diff: chrome/browser/ui/views/ash/panel_view_aura.cc

Issue 10868116: Pass result of blockage across content API when new tab blocked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/panel_view_aura.cc
===================================================================
--- chrome/browser/ui/views/ash/panel_view_aura.cc (revision 154307)
+++ chrome/browser/ui/views/ash/panel_view_aura.cc (working copy)
@@ -67,7 +67,7 @@
virtual void HandleMouseDown() OVERRIDE;
virtual void UpdatePreferredSize(content::WebContents* source,
const gfx::Size& pref_size) OVERRIDE;
- virtual void AddNewContents(content::WebContents* source,
+ virtual bool AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
@@ -139,7 +139,7 @@
// This handles launching a new page from within the panel.
// TODO(stevenjb): Determine whether or not this is the desired/expected
// behavior for panels.
-void PanelHost::AddNewContents(content::WebContents* source,
+bool PanelHost::AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
@@ -147,9 +147,10 @@
Browser* browser = browser::FindLastActiveWithProfile(
Profile::FromBrowserContext(new_contents->GetBrowserContext()));
if (browser) {
- chrome::AddWebContents(browser, NULL, new_contents, disposition,
- initial_pos, user_gesture);
+ return chrome::AddWebContents(browser, NULL, new_contents, disposition,
+ initial_pos, user_gesture);
}
+ return true;
}
void PanelHost::RenderViewCreated(content::RenderViewHost* render_view_host) {

Powered by Google App Engine
This is Rietveld 408576698