Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/cocoa/web_dialog_window_controller.mm

Issue 10868116: Pass result of blockage across content API when new tab blocked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/web_dialog_window_controller.mm
===================================================================
--- chrome/browser/ui/cocoa/web_dialog_window_controller.mm (revision 154307)
+++ chrome/browser/ui/cocoa/web_dialog_window_controller.mm (working copy)
@@ -74,7 +74,7 @@
virtual content::WebContents* OpenURLFromTab(
content::WebContents* source,
const content::OpenURLParams& params) OVERRIDE;
- virtual void AddNewContents(content::WebContents* source,
+ virtual bool AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
@@ -229,7 +229,7 @@
return WebDialogWebContentsDelegate::OpenURLFromTab(source, params);
}
-void WebDialogWindowDelegateBridge::AddNewContents(
+bool WebDialogWindowDelegateBridge::AddNewContents(
content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
@@ -237,9 +237,9 @@
bool user_gesture) {
if (delegate_ && delegate_->HandleAddNewContents(
source, new_contents, disposition, initial_pos, user_gesture)) {
- return;
+ return true;
}
- WebDialogWebContentsDelegate::AddNewContents(
+ return WebDialogWebContentsDelegate::AddNewContents(
source, new_contents, disposition, initial_pos, user_gesture);
}

Powered by Google App Engine
This is Rietveld 408576698