Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: chrome/browser/ui/browser.cc

Issue 10868116: Pass result of blockage across content API when new tab blocked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
===================================================================
--- chrome/browser/ui/browser.cc (revision 154307)
+++ chrome/browser/ui/browser.cc (working copy)
@@ -1301,13 +1301,13 @@
command_controller_->TabStateChanged();
}
-void Browser::AddNewContents(WebContents* source,
+bool Browser::AddNewContents(WebContents* source,
WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
bool user_gesture) {
- chrome::AddWebContents(this, source, new_contents, disposition, initial_pos,
- user_gesture);
+ return chrome::AddWebContents(
+ this, source, new_contents, disposition, initial_pos, user_gesture);
}
void Browser::ActivateContents(WebContents* contents) {
@@ -1508,7 +1508,7 @@
return true;
}
-void Browser::WebContentsCreated(WebContents* source_contents,
+bool Browser::WebContentsCreated(WebContents* source_contents,
int64 source_frame_id,
const GURL& target_url,
WebContents* new_contents) {
@@ -1529,6 +1529,8 @@
chrome::NOTIFICATION_RETARGETING,
content::Source<Profile>(profile_),
content::Details<RetargetingDetails>(&details));
+
+ return true;
}
void Browser::ContentRestrictionsChanged(WebContents* source) {

Powered by Google App Engine
This is Rietveld 408576698