Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/tab_contents/background_contents.h

Issue 10868116: Pass result of blockage across content API when new tab blocked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/balloon_host.cc ('k') | chrome/browser/tab_contents/background_contents.cc » ('j') | chrome/browser/ui/views/external_tab_container_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/background_contents.h
===================================================================
--- chrome/browser/tab_contents/background_contents.h (revision 154307)
+++ chrome/browser/tab_contents/background_contents.h (working copy)
@@ -30,8 +30,8 @@
public:
// Called by AddNewContents(). Asks the delegate to attach the opened
// WebContents to a suitable container (e.g. browser) or to show it if it's
- // a popup window.
- virtual void AddWebContents(content::WebContents* new_contents,
+ // a popup window. Returns false if the popup was blocked.
+ virtual bool AddWebContents(content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
bool user_gesture) = 0;
@@ -53,7 +53,7 @@
virtual bool ShouldSuppressDialogs() OVERRIDE;
virtual void DidNavigateMainFramePostCommit(
content::WebContents* tab) OVERRIDE;
- virtual void AddNewContents(content::WebContents* source,
+ virtual bool AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
« no previous file with comments | « chrome/browser/notifications/balloon_host.cc ('k') | chrome/browser/tab_contents/background_contents.cc » ('j') | chrome/browser/ui/views/external_tab_container_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698