Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: content/public/browser/web_contents.h

Issue 10868116: Pass result of blockage across content API when new tab blocked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
===================================================================
--- content/public/browser/web_contents.h (revision 153532)
+++ content/public/browser/web_contents.h (working copy)
@@ -225,8 +225,9 @@
// Window management ---------------------------------------------------------
- // Adds a new tab or window with the given already-created contents.
- virtual void AddNewContents(WebContents* new_contents,
+ // Adds a new tab or window with the given already-created contents. Returns
+ // false if the window or tab was blocked.
+ virtual bool AddNewContents(WebContents* new_contents,
jam 2012/08/29 00:07:23 can you get rid of this function altogether? most
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
bool user_gesture) = 0;

Powered by Google App Engine
This is Rietveld 408576698