Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: nacl_bindings_generator/interface.py

Issue 1086743002: Support pointers in the NaCl bindings generator. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Tweaks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « nacl_bindings_generator/generate_nacl_bindings.py ('k') | nacl_bindings_generator/interface_dsl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: nacl_bindings_generator/interface.py
diff --git a/nacl_bindings_generator/interface.py b/nacl_bindings_generator/interface.py
index 62a3f34ce7b0bfa5aab40694b3740195bfa5e850..0f6af62de9a7b415f62ab2fe7c5fc39e558b5362 100644
--- a/nacl_bindings_generator/interface.py
+++ b/nacl_bindings_generator/interface.py
@@ -27,9 +27,15 @@ def MakeInterface():
f.Param('num_bytes').In('uint64_t')
f.Param('buffer').Out('void*')
f.Param('flags').In('MojoMapBufferFlags')
+ # TODO(ncbray): support mmaping.
+ # https://code.google.com/p/chromium/issues/detail?id=401761
+ f.IsBrokenInNaCl()
f = mojo.Func('MojoUnmapBuffer', 'MojoResult')
f.Param('buffer').In('void*')
+ # TODO(ncbray): support mmaping.
+ # https://code.google.com/p/chromium/issues/detail?id=401761
+ f.IsBrokenInNaCl()
f = mojo.Func('MojoCreateDataPipe', 'MojoResult')
p = f.Param('options')
@@ -48,6 +54,9 @@ def MakeInterface():
f.Param('buffer').Out('void*')
f.Param('buffer_num_bytes').InOut('uint32_t')
f.Param('flags').In('MojoWriteDataFlags')
+ # TODO(ncbray): support two-stage reads and writes.
+ # https://code.google.com/p/chromium/issues/detail?id=401761
+ f.IsBrokenInNaCl()
f = mojo.Func('MojoEndWriteData', 'MojoResult')
f.Param('data_pipe_producer_handle').In('MojoHandle')
@@ -64,6 +73,9 @@ def MakeInterface():
f.Param('buffer').Out('const void*')
f.Param('buffer_num_bytes').InOut('uint32_t')
f.Param('flags').In('MojoReadDataFlags')
+ # TODO(ncbray): support two-stage reads and writes.
+ # https://code.google.com/p/chromium/issues/detail?id=401761
+ f.IsBrokenInNaCl()
f = mojo.Func('MojoEndReadData', 'MojoResult')
f.Param('data_pipe_consumer_handle').In('MojoHandle')
« no previous file with comments | « nacl_bindings_generator/generate_nacl_bindings.py ('k') | nacl_bindings_generator/interface_dsl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698