Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

Issue 1086733002: Ensure tests have an active task runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
index f070f139fb73b30d27b1830cd9c324dc5e6655da..c7847964a55bb639159c5cee53fd48c8268ee385 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
@@ -4,7 +4,6 @@
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"
-#include "base/message_loop/message_loop.h"
#include "base/prefs/testing_pref_service.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h"
@@ -293,7 +292,6 @@ scoped_ptr<DataReductionProxyTestContext>
DataReductionProxyTestContext::Builder::Build() {
// Check for invalid builder combinations.
DCHECK(!(use_mock_config_ && use_config_client_));
- scoped_ptr<base::MessageLoopForIO> loop(new base::MessageLoopForIO());
unsigned int test_context_flags = 0;
scoped_refptr<base::SingleThreadTaskRunner> task_runner =
@@ -394,7 +392,7 @@ DataReductionProxyTestContext::Builder::Build() {
scoped_ptr<DataReductionProxyTestContext> test_context(
new DataReductionProxyTestContext(
- loop.Pass(), task_runner, pref_service.Pass(), net_log.Pass(),
+ task_runner, pref_service.Pass(), net_log.Pass(),
request_context_getter, mock_socket_factory_, io_data.Pass(),
settings.Pass(), storage_delegate.Pass(), raw_params,
test_context_flags));
@@ -406,7 +404,6 @@ DataReductionProxyTestContext::Builder::Build() {
}
DataReductionProxyTestContext::DataReductionProxyTestContext(
- scoped_ptr<base::MessageLoop> loop,
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
scoped_ptr<TestingPrefServiceSimple> simple_pref_service,
scoped_ptr<net::TestNetLog> net_log,
@@ -418,7 +415,6 @@ DataReductionProxyTestContext::DataReductionProxyTestContext(
TestDataReductionProxyParams* params,
unsigned int test_context_flags)
: test_context_flags_(test_context_flags),
- loop_(loop.Pass()),
task_runner_(task_runner),
simple_pref_service_(simple_pref_service.Pass()),
net_log_(net_log.Pass()),

Powered by Google App Engine
This is Rietveld 408576698