chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc - Issue 1086733002: Ensure tests have an active task runner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

Issue 1086733002: Ensure tests have an active task runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/suggestions_combiner_unittest.cc ('k') | chromeos/dbus/services/service_provider_test_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc b/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

index 35517fa15adbb50add1532b28efb7fed286677dd..1f701a6067c5e30f63824dfd9903e15a018636e1 100644

--- a/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

+++ b/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

@@ -18,6 +18,7 @@

#include "chrome/browser/local_discovery/pwg_raster_converter.h"

#include "chrome/browser/ui/webui/print_preview/extension_printer_handler.h"

#include "chrome/test/base/testing_profile.h"

+#include "content/public/test/test_browser_thread_bundle.h"

#include "extensions/browser/api/printer_provider/printer_provider_api.h"

#include "extensions/browser/api/printer_provider/printer_provider_api_factory.h"

#include "extensions/browser/api/printer_provider/printer_provider_print_job.h"

@@ -370,7 +371,7 @@ class ExtensionPrinterHandlerTest : public testing::Test {

profile_ = profile_builder.Build();

extension_printer_handler_.reset(new ExtensionPrinterHandler(

- profile_.get(), message_loop_.task_runner()));

+ profile_.get(), base::MessageLoop::current()->task_runner()));

pwg_raster_converter_ = new FakePWGRasterConverter();

extension_printer_handler_->SetPwgRasterConverterForTesting(

@@ -389,7 +390,7 @@ class ExtensionPrinterHandlerTest : public testing::Test {

FakePWGRasterConverter* pwg_raster_converter_;

private:

- base::MessageLoop message_loop_;

+ content::TestBrowserThreadBundle thread_bundle_;

scoped_ptr<TestingProfile> profile_;