chrome/browser/notifications/extension_welcome_notification_unittest.cc - Issue 1086733002: Ensure tests have an active task runner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification_unittest.cc

Issue 1086733002: Ensure tests have an active task runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc ('k') | chrome/browser/password_manager/password_manager_internals_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification_unittest.cc

diff --git a/chrome/browser/notifications/extension_welcome_notification_unittest.cc b/chrome/browser/notifications/extension_welcome_notification_unittest.cc

index 88812628bbe9aca6460212a3f038c9083d9e0ad0..43d9d88386db24f1e4895d50b744e35d8cfcb882 100644

--- a/chrome/browser/notifications/extension_welcome_notification_unittest.cc

+++ b/chrome/browser/notifications/extension_welcome_notification_unittest.cc

@@ -14,6 +14,7 @@

#include "base/thread_task_runner_handle.h"

#include "chrome/browser/notifications/notification.h"

#include "chrome/common/pref_names.h"

+#include "chrome/test/base/testing_browser_process.h"

#include "chrome/test/base/testing_pref_service_syncable.h"

#include "chrome/test/base/testing_profile.h"

#include "components/pref_registry/pref_registry_syncable.h"

@@ -142,6 +143,7 @@ class ExtensionWelcomeNotificationTest : public testing::Test {

delegate_ = NULL;

welcome_notification_.reset();

profile_.reset();

+ TestingBrowserProcess::DeleteInstance();

thread_task_runner_handle_.reset();

task_runner_ = NULL;

}