Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2247)

Unified Diff: chrome/browser/media/webrtc_log_uploader_unittest.cc

Issue 1086733002: Ensure tests have an active task runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/lifetime/application_lifetime.cc ('k') | chrome/browser/metrics/thread_watcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_log_uploader_unittest.cc
diff --git a/chrome/browser/media/webrtc_log_uploader_unittest.cc b/chrome/browser/media/webrtc_log_uploader_unittest.cc
index 2994c8bc42107f94f69bb86f12b1c1180a102abd..c3bf5182e2e93df8a18e5e931d5513a6c45aa9f9 100644
--- a/chrome/browser/media/webrtc_log_uploader_unittest.cc
+++ b/chrome/browser/media/webrtc_log_uploader_unittest.cc
@@ -13,6 +13,8 @@
#include "base/strings/string_split.h"
#include "base/time/time.h"
#include "chrome/browser/media/webrtc_log_uploader.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
const char kTestTime[] = "time";
@@ -157,6 +159,7 @@ class WebRtcLogUploaderTest : public testing::Test {
EXPECT_EQ(dump_content, lines[i + 3]);
}
+ content::TestBrowserThreadBundle thread_bundle_;
base::FilePath test_list_path_;
};
@@ -247,8 +250,13 @@ TEST_F(WebRtcLogUploaderTest, AddRtpDumpsToPostedData) {
WebRtcLogUploadDoneData upload_done_data;
upload_done_data.log_path = temp_dir.path().AppendASCII("log");
+ scoped_ptr<Profile> profile(new TestingProfile());
+ scoped_refptr<WebRtcLoggingHandlerHost> host(
+ new WebRtcLoggingHandlerHost(profile.get()));
+
upload_done_data.incoming_rtp_dump = incoming_dump;
upload_done_data.outgoing_rtp_dump = outgoing_dump;
+ upload_done_data.host = host.get();
scoped_ptr<WebRtcLogBuffer> log(new WebRtcLogBuffer());
log->SetComplete();
« no previous file with comments | « chrome/browser/lifetime/application_lifetime.cc ('k') | chrome/browser/metrics/thread_watcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698