components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc - Issue 1086733002: Ensure tests have an active task runner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 1086733002: Ensure tests have an active task runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reduce to test fixes only. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/background/background_mode_manager_unittest.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

index 2b1a17b84a54014b7a87b63fd963c2ab6c5f5014..8ea465e5d65245475b7814721fa23fa8fe2668e6 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

@@ -143,6 +143,7 @@ TEST_F(DataReductionProxySettingsTest, TestContentLengths) {

}

TEST(DataReductionProxySettingsStandaloneTest, TestEndToEndSecureProxyCheck) {

+ base::MessageLoopForIO message_loop;

struct TestCase {

const char* response_headers;

const char* response_body;

@@ -227,6 +228,7 @@ TEST(DataReductionProxySettingsStandaloneTest, TestEndToEndSecureProxyCheck) {

}

TEST(DataReductionProxySettingsStandaloneTest, TestOnProxyEnabledPrefChange) {

+ base::MessageLoopForIO message_loop;

scoped_ptr<DataReductionProxyTestContext> drp_test_context =

DataReductionProxyTestContext::Builder()

.WithParamsFlags(DataReductionProxyParams::kAllowed |