Chromium Code Reviews| Index: runtime/vm/dart_api_impl_test.cc |
| diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc |
| index c439b416585ae1088fa12553aa111c6e60be0c8a..5be05a79b43a5128d879771e8e7a94e13e8e46a2 100644 |
| --- a/runtime/vm/dart_api_impl_test.cc |
| +++ b/runtime/vm/dart_api_impl_test.cc |
| @@ -796,6 +796,7 @@ TEST_CASE(IntegerValues) { |
| const int64_t kIntegerVal1 = 100; |
| const int64_t kIntegerVal2 = 0xffffffff; |
| const char* kIntegerVal3 = "0x123456789123456789123456789"; |
| + const uint64_t kIntegerVal4 = 0xffffffffffffffff; |
| Dart_Handle val1 = Dart_NewInteger(kIntegerVal1); |
| EXPECT(Dart_IsInteger(val1)); |
| @@ -829,6 +830,19 @@ TEST_CASE(IntegerValues) { |
| result = Dart_IntegerToHexCString(val3, &chars); |
| EXPECT_VALID(result); |
| EXPECT(!strcmp(kIntegerVal3, chars)); |
| + |
| + Dart_Handle val4 = Dart_NewIntegerFromUint64(kIntegerVal4); |
| + EXPECT_VALID(val4); |
| + uint64_t out4 = 0; |
| + result = Dart_IntegerToUint64(val4, &out4); |
| + EXPECT_VALID(result); |
| + EXPECT_EQ(kIntegerVal4, out4); |
| + |
| + Dart_Handle val5 = Dart_NewInteger(-1); |
| + EXPECT_VALID(val4); |
|
siva
2015/04/14 17:42:45
val5 here?
rmacnak
2015/04/14 17:51:46
Yes, done.
|
| + uint64_t out5 = 0; |
| + result = Dart_IntegerToUint64(val5, &out5); |
| + EXPECT(Dart_IsError(result)); |
| } |
| @@ -864,7 +878,7 @@ TEST_CASE(IntegerFitsIntoInt64) { |
| TEST_CASE(IntegerFitsIntoUint64) { |
| - Dart_Handle max = Dart_NewIntegerFromHexCString("0xFFFFFFFFFFFFFFFF"); |
| + Dart_Handle max = Dart_NewIntegerFromUint64(kMaxUint64); |
| EXPECT(Dart_IsInteger(max)); |
| bool fits = false; |
| Dart_Handle result = Dart_IntegerFitsIntoUint64(max, &fits); |