Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 1086703007: gpu_perftests: Use zero size gl surface for offscreen rendering (Closed)

Created:
5 years, 8 months ago by vignatti (out of this project)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dshwang, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu_perftests: Use zero size gl surface for offscreen rendering In GLX, most of the drivers can cope with both PBuffer and Surfaceless modes for offscreen rendering. In EGL though, Intel driver only works with Surfaceless. This CL changes all hardware platforms to use Surfaceless by forcing a zero size GL surface initialization. Ozone-GBM wasn't previously working because of that but now works fine. BUG=423481 TEST=gpu_perftests on GBM Committed: https://crrev.com/274eb3202c59d4842c191e924577e81f14044af5 Cr-Commit-Position: refs/heads/master@{#325514}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M gpu/perftests/texture_upload_perftest.cc View 2 chunks +10 lines, -1 line 2 comments Download

Messages

Total messages: 12 (3 generated)
vignatti (out of this project)
I believe dshwang@ will want to take a look on this one for his zero-copy ...
5 years, 8 months ago (2015-04-13 20:19:00 UTC) #2
reveman
+dcastagna
5 years, 8 months ago (2015-04-13 20:29:32 UTC) #4
Daniele Castagna
https://codereview.chromium.org/1086703007/diff/1/gpu/perftests/texture_upload_perftest.cc File gpu/perftests/texture_upload_perftest.cc (right): https://codereview.chromium.org/1086703007/diff/1/gpu/perftests/texture_upload_perftest.cc#newcode181 gpu/perftests/texture_upload_perftest.cc:181: base::MessageLoopForUI main_loop; Where in the backend is this message ...
5 years, 8 months ago (2015-04-14 15:38:38 UTC) #5
vignatti (out of this project)
https://codereview.chromium.org/1086703007/diff/1/gpu/perftests/texture_upload_perftest.cc File gpu/perftests/texture_upload_perftest.cc (right): https://codereview.chromium.org/1086703007/diff/1/gpu/perftests/texture_upload_perftest.cc#newcode181 gpu/perftests/texture_upload_perftest.cc:181: base::MessageLoopForUI main_loop; On 2015/04/14 15:38:38, Daniele Castagna wrote: > ...
5 years, 8 months ago (2015-04-14 16:39:16 UTC) #6
Daniele Castagna
On 2015/04/14 at 16:39:16, tiago.vignatti wrote: > https://codereview.chromium.org/1086703007/diff/1/gpu/perftests/texture_upload_perftest.cc > File gpu/perftests/texture_upload_perftest.cc (right): > > https://codereview.chromium.org/1086703007/diff/1/gpu/perftests/texture_upload_perftest.cc#newcode181 ...
5 years, 8 months ago (2015-04-16 19:53:36 UTC) #7
reveman
lgtm
5 years, 8 months ago (2015-04-16 20:00:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086703007/1
5 years, 8 months ago (2015-04-16 20:00:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 21:10:58 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 21:12:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/274eb3202c59d4842c191e924577e81f14044af5
Cr-Commit-Position: refs/heads/master@{#325514}

Powered by Google App Engine
This is Rietveld 408576698