Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 1086693004: [gcc 4.x] Initialize web_port_index to 0 to fix build error while using GCC 4.x toolchain. (Closed)

Created:
5 years, 8 months ago by vivekg_samsung
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gcc 4.x] Initialize web_port_index to 0 to fix build error while using GCC 4.x toolchain. Without the initialization, GCC throws the below error: error: ‘web_port_index’ may be used uninitialized in this function [-Werror=maybe-uninitialized] This looks like a gcc bug as we are handling both the types in the switch-case block. R=agoode@chromium.org, toyoshim@chromium.org Committed: https://crrev.com/5f288f453ba0eac7f7812041f6efb43b30448b56 Cr-Commit-Position: refs/heads/master@{#325191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/midi/midi_manager_alsa.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
vivekg
PTAL, thanks.
5 years, 8 months ago (2015-04-14 05:21:45 UTC) #2
Adam Goode
lgtm I am not a committer though, so you will need to wait for another ...
5 years, 8 months ago (2015-04-14 15:21:11 UTC) #3
Takashi Toyoshima
lgtm
5 years, 8 months ago (2015-04-15 04:29:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086693004/1
5 years, 8 months ago (2015-04-15 04:30:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 06:11:27 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 06:13:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f288f453ba0eac7f7812041f6efb43b30448b56
Cr-Commit-Position: refs/heads/master@{#325191}

Powered by Google App Engine
This is Rietveld 408576698