Issue 1086673002: Revert "ES6: Number and Boolean prototype should be ordinary objects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1086673002: Revert "ES6: Number and Boolean prototype should be ordinary objects" (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)

Modified:
5 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert "ES6: Number and Boolean prototype should be ordinary objects" This reverts commit e965a1f84a7a4024d40680ef63e82abeaef867fd. The reason is that it breaks jsfiddle.com BUG=476437, v8:4001 LOG=N R=rossberg@chromium.org Committed: https://crrev.com/0e539d1ca9df799d547a0fd1bd21f9c54b668c2b Cr-Commit-Position: refs/heads/master@{#27791}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -68 lines)			Patch
M	src/v8natives.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/es6/prototype-ordinary-objects.js	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	test/test262-es6/test262-es6.status	View	2 chunks	+53 lines, -0 lines	0 comments	Download
M	test/test262/test262.status	View	1 chunk	+0 lines, -55 lines	0 comments	Download

Total messages: 6 (1 generated)

arv (Not doing code reviews)

I decided to keep the test but with modifications since it is testing other prototype ...

5 years, 8 months ago (2015-04-13 14:54:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086673002/1

5 years, 8 months ago (2015-04-13 16:00:48 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-13 16:21:22 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0e539d1ca9df799d547a0fd1bd21f9c54b668c2b
Cr-Commit-Position: refs/heads/master@{#27791}