Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 108663009: orphans and widows should be positive integer. (Closed)

Created:
7 years ago by tasak
Modified:
7 years ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

orphans and widows should be positive integer. spec link: http://www.w3.org/TR/CSS2/page.html#propdef-orphans BUG=327725 TEST=fast/css/negative-orphans-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164046

Patch Set 1 #

Patch Set 2 : Fixed animations/interpolation/orphans-interpolation.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -19 lines) Patch
M LayoutTests/animations/interpolation/orphans-interpolation.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/orphans-interpolation-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
A LayoutTests/fast/css/negative-orphans-crash.html View 1 chunk +27 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/negative-orphans-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/virtual/legacy-animations-engine/animations/interpolation/orphans-interpolation-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tasak
7 years ago (2013-12-17 06:16:43 UTC) #1
tkent
lgtm
7 years ago (2013-12-17 06:21:55 UTC) #2
tasak
Thank you for reviewing. On 2013/12/17 06:21:55, tkent wrote: > lgtm I found that animations/interpolation/orphans-interpolation.html ...
7 years ago (2013-12-17 08:42:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/108663009/20001
7 years ago (2013-12-18 01:56:48 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-18 02:54:25 UTC) #5
Message was sent while issue was closed.
Change committed as 164046

Powered by Google App Engine
This is Rietveld 408576698