Additional OAuth2 tests

Additional OAuth2 tests for ChromeOS
- authentication attempt for invalid OAuth2 refresh token
- authentication of an existing user  

BUG=none
TEST=OAuth2.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241581

[xiyuan, 2013-12-17 17:12:57]

LGTM

https://codereview.chromium.org/108663008/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/oauth2_browsertest.cc (right):

https://codereview.chromium.org/108663008/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/oauth2_browsertest.cc:236: };
nit: DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/108663008/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/oauth2_browsertest.cc:387: // that was generated
in PRE_MergeSession test.
nit: Comment why merge session fails in this test. It is easy to miss that it is
because fake gaia is not setup.

https://codereview.chromium.org/108663008/diff/1/google_apis/gaia/fake_gaia.h
File google_apis/gaia/fake_gaia.h (left):

https://codereview.chromium.org/108663008/diff/1/google_apis/gaia/fake_gaia.h...
google_apis/gaia/fake_gaia.h:128: std::string* value);
My SAMLTest CL uses GetQueryParameter to extract form param in FakeSamlIdp.

[zel, 2013-12-17 17:23:15]

https://codereview.chromium.org/108663008/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/oauth2_browsertest.cc (right):

https://codereview.chromium.org/108663008/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/oauth2_browsertest.cc:236: };
On 2013/12/17 17:12:57, xiyuan wrote:
> nit: DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/108663008/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/oauth2_browsertest.cc:387: // that was generated
in PRE_MergeSession test.
On 2013/12/17 17:12:57, xiyuan wrote:
> nit: Comment why merge session fails in this test. It is easy to miss that it
is
> because fake gaia is not setup.

Done.

https://codereview.chromium.org/108663008/diff/1/google_apis/gaia/fake_gaia.h
File google_apis/gaia/fake_gaia.h (left):

https://codereview.chromium.org/108663008/diff/1/google_apis/gaia/fake_gaia.h...
google_apis/gaia/fake_gaia.h:128: std::string* value);
On 2013/12/17 17:12:57, xiyuan wrote:
> My SAMLTest CL uses GetQueryParameter to extract form param in FakeSamlIdp.

I will expose this method once I merge everything.

[commit-bot: I haz the power, 2013-12-18 00:26:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/108663008/80001

[commit-bot: I haz the power, 2013-12-18 00:46:22]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-18 00:58:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/108663008/100001

[commit-bot: I haz the power, 2013-12-18 01:20:21]

Retried try job too often on linux_chromeos for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, check_deps2git, chromeos_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
dbus_unittests, device_unittests, events_unittests, google_apis_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, net_unittests, ppapi_unittests, printing_unittests,
sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-18 01:33:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/108663008/120001

[commit-bot: I haz the power, 2013-12-18 04:24:26]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-18 05:02:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/108663008/140001

[commit-bot: I haz the power, 2013-12-18 07:36:24]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-12-18 15:03:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/108663008/140001

[Roger Tawa OOO till Jul 10th, 2013-12-18 16:36:17]

google_apis lgtm

How fragile is this?  That is, what's the chance that gaia changes something and
the tests continue to pass even though the code is broken?

[zel, 2013-12-18 17:26:00]

On 2013/12/18 16:36:17, Roger Tawa wrote:
> google_apis lgtm
> 
> How fragile is this?  That is, what's the chance that gaia changes something
and
> the tests continue to pass even though the code is broken?

Yes, of course that can happen if GAIA side changes something. That also goes
for all other Google APIs (i.e. drive) that we are using. For those reasons,
browser_tests alone aren't 100% enough to prevent such regressions. For GAIA
part on ChromeOS, we also need to have a) continuous tests (BVTs) that work
against their staging environment, b) GAIA-side unit tests that cover our use
cases.

[commit-bot: I haz the power, 2013-12-18 17:31:47]

Change committed as 241581