Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1086613003: Revert of Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. (Closed)

Created:
5 years, 8 months ago by johnme
Modified:
5 years, 8 months ago
Reviewers:
ncarter (slow), nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@b444955
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. (patchset #2 id:20001 of https://codereview.chromium.org/1070553005/) Reason for revert: Tentative revert to try to fix BrowserTest.WindowOpenClose, which is consistently failing on chromium.webkit Mac10.6 Tests and Mac10.8 Tests. It times out during ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete and gets killed whilst waiting for the navigations. It started failing between https://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/474 and https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/29002, so the blamelists are: Chromium: https://chromium.googlesource.com/chromium/src.git/+log/96626920573e30a2cd02040b7ccec2c56f38b4db..274eb3202c59d4842c191e924577e81f14044af5 Blink: https://chromium.googlesource.com/chromium/blink/+log/7f9db67d6a96399f8e4eae490efa83aa1b59107f..4dd6623614cff05eb3c18cd96f8d6ed089b7965b This is the only patch that seems at all relevant from amongst those... Original issue's description: > Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. > > In the FrameTree unittests, illustrate the liveness of frames in the ASCII > dumps. Update some tests so that children aren't born to dead parents. > > BUG=474231 > > Committed: https://crrev.com/ad74a7e371149624d91f96cf662f70af6d18787f > Cr-Commit-Position: refs/heads/master@{#325508} TBR=nasko@chromium.org,nick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474231 Committed: https://crrev.com/5e69a55db837879b5d4ca4b0935cf61742e09751 Cr-Commit-Position: refs/heads/master@{#325629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M content/browser/frame_host/frame_tree_unittest.cc View 4 chunks +2 lines, -9 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
johnme
Created Revert of Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted.
5 years, 8 months ago (2015-04-17 14:03:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086613003/1
5 years, 8 months ago (2015-04-17 14:04:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 14:05:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5e69a55db837879b5d4ca4b0935cf61742e09751 Cr-Commit-Position: refs/heads/master@{#325629}
5 years, 8 months ago (2015-04-17 14:06:33 UTC) #4
Stephen Chennney
5 years, 8 months ago (2015-04-17 17:43:03 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1091303003/ by schenney@chromium.org.

The reason for reverting is: Relanding because the test is still failing even
with this patch reverted..

Powered by Google App Engine
This is Rietveld 408576698