DescriptionRevert of Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. (patchset #2 id:20001 of https://codereview.chromium.org/1070553005/)
Reason for revert:
Tentative revert to try to fix BrowserTest.WindowOpenClose, which is consistently failing on chromium.webkit Mac10.6 Tests and Mac10.8 Tests.
It times out during ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete and gets killed whilst waiting for the navigations.
It started failing between https://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/474 and https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/29002, so the blamelists are:
Chromium: https://chromium.googlesource.com/chromium/src.git/+log/96626920573e30a2cd02040b7ccec2c56f38b4db..274eb3202c59d4842c191e924577e81f14044af5
Blink: https://chromium.googlesource.com/chromium/blink/+log/7f9db67d6a96399f8e4eae490efa83aa1b59107f..4dd6623614cff05eb3c18cd96f8d6ed089b7965b
This is the only patch that seems at all relevant from amongst those...
Original issue's description:
> Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted.
>
> In the FrameTree unittests, illustrate the liveness of frames in the ASCII
> dumps. Update some tests so that children aren't born to dead parents.
>
> BUG=474231
>
> Committed: https://crrev.com/ad74a7e371149624d91f96cf662f70af6d18787f
> Cr-Commit-Position: refs/heads/master@{#325508}
TBR=nasko@chromium.org,nick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=474231
Committed: https://crrev.com/5e69a55db837879b5d4ca4b0935cf61742e09751
Cr-Commit-Position: refs/heads/master@{#325629}
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|