Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1086583002: Remove android_webview_build completely. (Closed)

Created:
5 years, 8 months ago by Torne
Modified:
5 years, 8 months ago
Reviewers:
cjhopman, tfarina
CC:
chromium-reviews, tfarina, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove android_webview_build completely. Remove the final remaining references to android_webview_build and delete the variable itself from common.gypi and config.gni. BUG=440793 Committed: https://crrev.com/62adf72afec378e8e22a8c3f549b86100ebfea2f Cr-Commit-Position: refs/heads/master@{#325033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M build/common.gypi View 7 chunks +6 lines, -29 lines 0 comments Download
M build/config/android/config.gni View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Torne
5 years, 8 months ago (2015-04-13 11:33:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086583002/1
5 years, 8 months ago (2015-04-13 11:33:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/55840)
5 years, 8 months ago (2015-04-13 11:41:44 UTC) #6
cjhopman
lgtm
5 years, 8 months ago (2015-04-13 21:15:01 UTC) #7
tfarina
gn docs lgtm
5 years, 8 months ago (2015-04-13 21:20:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086583002/1
5 years, 8 months ago (2015-04-14 11:18:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 13:38:42 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 13:39:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62adf72afec378e8e22a8c3f549b86100ebfea2f
Cr-Commit-Position: refs/heads/master@{#325033}

Powered by Google App Engine
This is Rietveld 408576698