Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1086563005: [Chromoting] Use MockConnection for bump scrolling browser test. (Closed)

Created:
5 years, 8 months ago by kelvinp
Modified:
5 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@IncludeBTinWebapp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Use MockConnection for bump scrolling browser test. This CL uses the MockConnection for bump scrolling browser test. This will make the test more resilient to network failures. BUG=478331 Committed: https://crrev.com/57cdc723f71b691b10ddc8f10f9a56897acb6886 Cr-Commit-Position: refs/heads/master@{#326980}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -4 lines) Patch
M chrome/test/remoting/remote_desktop_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/browser_test/bump_scroll_browser_test.js View 2 chunks +12 lines, -3 lines 0 comments Download
M remoting/webapp/crd/js/mock_client_plugin.js View 4 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kelvinp
PTAL
5 years, 8 months ago (2015-04-25 00:25:55 UTC) #2
Jamie
lgtm
5 years, 8 months ago (2015-04-25 00:31:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086563005/20001
5 years, 8 months ago (2015-04-25 22:16:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-25 23:08:54 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 23:09:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57cdc723f71b691b10ddc8f10f9a56897acb6886
Cr-Commit-Position: refs/heads/master@{#326980}

Powered by Google App Engine
This is Rietveld 408576698