Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1086563003: Fix SEGV in ErrorScreenHandler::HandleHideCaptivePortal. (Closed)

Created:
5 years, 8 months ago by Ivan Podogov
Modified:
5 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SEGV in ErrorScreenHandler::HandleHideCaptivePortal. BUG=475936 Committed: https://crrev.com/30cec5f6f3ee4e5cfbd41009bc21c0f5dba0c666 Cr-Commit-Position: refs/heads/master@{#325213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ivan Podogov
PTAL
5 years, 8 months ago (2015-04-15 08:18:30 UTC) #2
Nikita (slow)
lgtm
5 years, 8 months ago (2015-04-15 08:22:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086563003/1
5 years, 8 months ago (2015-04-15 08:22:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 08:55:10 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 08:56:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30cec5f6f3ee4e5cfbd41009bc21c0f5dba0c666
Cr-Commit-Position: refs/heads/master@{#325213}

Powered by Google App Engine
This is Rietveld 408576698