Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Issue 1086563002: [Merge to M43 branch] Postpone check if password form is loaded from store (Closed)

Created:
5 years, 8 months ago by dvadym
Modified:
5 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

In some cases we encounter situation when in processing onSubmit of password form we didn't receive information from password store yet. For example this can happen when JavaScript creates password form after submission and submit it (as for nytimes.com). To process such situation this CL postpones checking if password form fetched from store until moment when we are going to decide if we should save it. In order to process this correctly creating pending credentials in PasswordManager was moved to separate method and it is called only when both events happen - form submission and fetching from store finished. BUG=470322 Review URL: https://codereview.chromium.org/1050903002 Cr-Commit-Position: refs/heads/master@{#324400} (cherry picked from commit f46ff48284131eba449796a932ec32290b03a403) R=vabr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/037c0924bcdc0372df29ee77891f6653880b6ed4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -134 lines) Patch
M components/password_manager/core/browser/password_form_manager.h View 3 chunks +10 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 5 chunks +136 lines, -113 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 4 chunks +20 lines, -20 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
dvadym
Hi Vaclav, Could you please review this merge issue? Best regards, Vadym
5 years, 8 months ago (2015-04-13 10:55:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086563002/1
5 years, 8 months ago (2015-04-13 10:58:01 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-13 10:58:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086563002/1
5 years, 8 months ago (2015-04-13 11:41:23 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-13 11:41:26 UTC) #9
vabr (Chromium)
This merge of https://codereview.chromium.org/1050903002 LGTM. Thanks! Vaclav
5 years, 8 months ago (2015-04-13 11:46:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086563002/1
5 years, 8 months ago (2015-04-13 11:53:08 UTC) #12
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 8 months ago (2015-04-13 11:53:11 UTC) #14
vabr (Chromium)
Committed patchset #1 (id:1) manually as 037c0924bcdc0372df29ee77891f6653880b6ed4 (presubmit successful).
5 years, 8 months ago (2015-04-13 13:34:18 UTC) #15
vabr (Chromium)
5 years, 8 months ago (2015-04-13 13:35:55 UTC) #16
Message was sent while issue was closed.
On 2015/04/13 13:34:18, vabr (Chromium) wrote:
> Committed patchset #1 (id:1) manually as
> 037c0924bcdc0372df29ee77891f6653880b6ed4 (presubmit successful).

I landed this CL on dvadym's behalf. He is already a committer, but is not on
some manually updated list yet, and therefore could not "git cl land" this.

Cheers,
Vaclav

Powered by Google App Engine
This is Rietveld 408576698