Chromium Code Reviews
DescriptionIn some cases we encounter situation when in processing onSubmit of password form we didn't receive information from password store yet. For example this can happen when JavaScript creates password form after submission and submit it (as for nytimes.com).
To process such situation this CL postpones checking if password form fetched from store until moment when we are going to decide if we should save it.
In order to process this correctly creating pending credentials in PasswordManager was moved to separate method and it is called only when both events happen - form submission and fetching from store finished.
BUG=470322
Review URL: https://codereview.chromium.org/1050903002
Cr-Commit-Position: refs/heads/master@{#324400}
(cherry picked from commit f46ff48284131eba449796a932ec32290b03a403)
R=vabr@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/037c0924bcdc0372df29ee77891f6653880b6ed4
Patch Set 1 #
Messages
Total messages: 16 (6 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||