Issue 108653015: [webcrypto] Some fixes for HMAC

Issue 108653015: [webcrypto] Some fixes for HMAC (Closed)

Created:
7 years ago by eroman

Modified:
7 years ago

Reviewers:
Bryan Eyler, Ryan Sleevi

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, padolph, Bryan Eyler

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[webcrypto] Some fixes for HMAC * Wire up HMAC SHA224, HMAC SHA384, HMAC SHA512 for NSS. * When generating an HMAC key and the key length was not specified use the underlying block size for the key length (as this is the maximum length of the key). The OpenSSL version had a bug where it would not select the block size. * Fix a test which intended to check randomness. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242149

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -59 lines)			Patch
M	content/renderer/webcrypto/webcrypto_impl_nss.cc	View	5 chunks	+11 lines, -36 lines	0 comments	Download
M	content/renderer/webcrypto/webcrypto_impl_openssl.cc	View	2 chunks	+1 line, -22 lines	0 comments	Download
M	content/renderer/webcrypto/webcrypto_impl_unittest.cc	View	3 chunks	+63 lines, -1 line	0 comments	Download
M	content/renderer/webcrypto/webcrypto_util.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/webcrypto/webcrypto_util.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/108653015/20001

7 years ago (2013-12-20 02:16:10 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108435

7 years ago (2013-12-20 10:29:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/108653015/20001

7 years ago (2013-12-20 18:12:00 UTC) #6

Message was sent while issue was closed.

Change committed as 242149

Expand Messages | Collapse Messages