Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1086523004: Revert of Revert of Roll Android SDK and AppCompat. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Roll Android SDK and AppCompat. (patchset #1 id:1 of https://codereview.chromium.org/1092843003/) Reason for revert: Downstream needs a fix in styles.xml to roll this in. Original issue's description: > Revert of Roll Android SDK and AppCompat. (patchset #2 id:20001 of https://codereview.chromium.org/1101633003/) > > Reason for revert: > Breaks downstream Chrome Android ToT instrumentation test. > BUG=480285 > > Original issue's description: > > Roll Android SDK and AppCompat. > > > > - Android SDK rolls to API 22 rev 2 > > (no API changes, just bug fixes) > > - Android Support Library rolls to 22.1.0 > > > > BUG=479858 > > > > Committed: https://crrev.com/a068236fabb7a1925df7494bd668c2b58b26979a > > Cr-Commit-Position: refs/heads/master@{#326437} > > TBR=newt@chromium.org,cjhopman@chromium.org,aurimas@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=479858 > > Committed: https://crrev.com/dd703b9316d9b346ec1bf6ec357884d40ffe80e6 > Cr-Commit-Position: refs/heads/master@{#326484} TBR=newt@chromium.org,cjhopman@chromium.org,pasko@chromium.org,azarchs@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480285 Committed: https://crrev.com/d90131fcdc10b4cdacc3be1e7bac78446708edad Cr-Commit-Position: refs/heads/master@{#326583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/process_resources.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Created Revert of Revert of Roll Android SDK and AppCompat.
5 years, 8 months ago (2015-04-23 18:20:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086523004/1
5 years, 8 months ago (2015-04-23 18:22:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 18:24:50 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 18:26:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d90131fcdc10b4cdacc3be1e7bac78446708edad
Cr-Commit-Position: refs/heads/master@{#326583}

Powered by Google App Engine
This is Rietveld 408576698