Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1086503002: X87: Disable the test case for X87 since f3338dd3b01c (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Disable the test case for X87 since f3338dd3b01c The overwrite-builtins test cases will throw one expected exception and the exception message should include the source position in the JS file. But crankshaft compiler does not generate the source position for it when creating the flow graph by default. The source position information is always zero. So it failed when comparing with the reference file. If we use crankshaft compiler on IA32 platform to run this test case, it has the same failure. BUG= Committed: https://crrev.com/31a3d5fcd2157bdc002ec7f581905e659eac707b Cr-Commit-Position: refs/heads/master@{#27807}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M test/message/message.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-13 09:03:23 UTC) #3
Michael Starzinger
I have the strong suspicion that this will be fixed by one of my pending ...
5 years, 8 months ago (2015-04-13 20:03:21 UTC) #4
Michael Starzinger
Ah, I misread the test case, it's not actually performing a call, it's loading a ...
5 years, 8 months ago (2015-04-13 20:07:01 UTC) #5
Weiliang
lgtm
5 years, 8 months ago (2015-04-14 01:32:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086503002/20001
5 years, 8 months ago (2015-04-14 01:33:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1964)
5 years, 8 months ago (2015-04-14 01:44:46 UTC) #10
Weiliang
On 2015/04/14 01:44:46, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-14 01:47:42 UTC) #11
Michael Starzinger
LGTM. I still think we should add the missing source position.
5 years, 8 months ago (2015-04-14 07:55:20 UTC) #12
chunyang.dai
Hi, Michael. Thank you very much to review it. I will land it first. If ...
5 years, 8 months ago (2015-04-14 08:03:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086503002/20001
5 years, 8 months ago (2015-04-14 08:04:10 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-14 08:05:40 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31a3d5fcd2157bdc002ec7f581905e659eac707b Cr-Commit-Position: refs/heads/master@{#27807}
5 years, 8 months ago (2015-04-14 08:05:54 UTC) #17
danno
5 years, 8 months ago (2015-04-14 08:24:52 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698