Omnibox: Bug Fixes for Shortcuts Inlining

chrome/browser/autocomplete/history_provider.h

Index: chrome/browser/autocomplete/history_provider.h
diff --git a/chrome/browser/autocomplete/history_provider.h b/chrome/browser/autocomplete/history_provider.h
index 705ab4cbf7f8b055536ad2e85a37f9395bb35078..7144fb9b4ea7e1b5e2e43b5c1f97c4090c291ba1 100644
--- a/chrome/browser/autocomplete/history_provider.h
+++ b/chrome/browser/autocomplete/history_provider.h
@@ -18,16 +18,6 @@ class HistoryProvider : public AutocompleteProvider {
  public:
   virtual void DeleteMatch(const AutocompleteMatch& match) OVERRIDE;
 
- protected:
-  HistoryProvider(AutocompleteProviderListener* listener,
-                  Profile* profile,
-                  AutocompleteProvider::Type type);
-  virtual ~HistoryProvider();
-
-  // Finds and removes the match from the current collection of matches and
-  // backing data.
-  void DeleteMatchFromMatches(const AutocompleteMatch& match);
-
   // Fixes up user URL input to make it more possible to match against.  Among
   // many other things, this takes care of the following:
   // * Prepending file:// to file URLs
@@ -42,6 +32,16 @@ class HistoryProvider : public AutocompleteProvider {
   // providers generally can't do anything with).
   static bool FixupUserInput(AutocompleteInput* input);

[Peter Kasting, 2013/12/17 23:04:22]

Perhaps we should actually move this to AutocompleteProvider's protected section
instead of HistoryProvider's public section?

[Mark P, 2013/12/19 23:18:58]

I'm not sure.  It sounds like you're not either.  I'm slightly inclined to leave
it where it is because I think it's best deserves to be in a URL-focused class. 
After all, it kind of assuming the input is URL-like in doing its fixups; I'm
worried that if we put it in AutocompleteProvider (at least without changing the
name) then it'll be inviting misuse.

[Peter Kasting, 2013/12/19 23:32:27]

Hmm.  I guess I don't have that sense.  It seems like if this is useful for
non-history providers, making it available to non-history providers is probably
better.  Keeping it in HistoryProvider doesn't just make it seem "URL-focused",
it makes it seem like this is only useful when the history provider is actually
involved somehow.

I don't feel strongly enough to mandate a change, though, so do what you think
best.

[Mark P, 2013/12/20 00:39:20]

Done.  Had to move TrimHttpPrefix() too.

 
+ protected:
+  HistoryProvider(AutocompleteProviderListener* listener,
+                  Profile* profile,
+                  AutocompleteProvider::Type type);
+  virtual ~HistoryProvider();
+
+  // Finds and removes the match from the current collection of matches and
+  // backing data.
+  void DeleteMatchFromMatches(const AutocompleteMatch& match);
+
   // Trims "http:" and up to two subsequent slashes from |url|.  Returns the
   // number of characters that were trimmed.
   // NOTE: For a view-source: URL, this will trim from after "view-source:" and