Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.h

Issue 108643002: ABANDONED: Remove Chrome dependencies from TestExtensionPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs_unittest.h
diff --git a/chrome/browser/extensions/extension_prefs_unittest.h b/chrome/browser/extensions/extension_prefs_unittest.h
index fc0ae8e0521ae21fae259209e7484d7d708cc758..3ab1885edc2a361b417d21175bce1cc314c049f7 100644
--- a/chrome/browser/extensions/extension_prefs_unittest.h
+++ b/chrome/browser/extensions/extension_prefs_unittest.h
@@ -11,6 +11,7 @@
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
+class PrefServiceFactory;
class Value;
}
@@ -24,7 +25,10 @@ class Extension;
// Base class for extension preference-related unit tests.
class ExtensionPrefsTest : public testing::Test {
public:
- ExtensionPrefsTest();
+ // Takes ownership of and uses |custom_pref_service_factory| if non-NULL;
+ // uses a standard base::PrefServiceFactory otherwise.
+ explicit ExtensionPrefsTest(
+ base::PrefServiceFactory* custom_pref_service_factory);
virtual ~ExtensionPrefsTest();
// This function will get called once, and is the right place to do operations
@@ -60,7 +64,8 @@ class PrefsPrepopulatedTestBase : public ExtensionPrefsTest {
public:
static const size_t kNumInstalledExtensions = 4;
- PrefsPrepopulatedTestBase();
+ PrefsPrepopulatedTestBase(
+ base::PrefServiceFactory* custom_pref_service_factory);
virtual ~PrefsPrepopulatedTestBase();
Extension* extension1() { return extension1_.get(); }

Powered by Google App Engine
This is Rietveld 408576698