ABANDONED: Remove Chrome dependencies from TestExtensionPrefs.

chrome/browser/extensions/chrome_app_sorting_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_app_sorting.h"
 
 #include <map>
 
 #include "chrome/browser/extensions/extension_prefs_unittest.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "extensions/common/manifest_constants.h"
 #include "sync/api/string_ordinal.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace extensions {
 
 namespace keys = manifest_keys;
 
 class ChromeAppSortingTest : public ExtensionPrefsTest {
+ public:
+  ChromeAppSortingTest() : ExtensionPrefsTest(NULL) {}
+
  protected:
   ChromeAppSorting* app_sorting() {
     return static_cast<ChromeAppSorting*>(prefs()->app_sorting());
   }
 };
 
 class ChromeAppSortingAppLocation : public ChromeAppSortingTest {
  public:
   virtual void Initialize() OVERRIDE {
     extension_ = prefs_.AddExtension("not_an_app");
@@ skipping 112 matching lines @@
  private:
   syncer::StringOrdinal first_page_;
   scoped_refptr<Extension> extension_;
 };
 TEST_F(ChromeAppSortingPageOrdinal, ChromeAppSortingPageOrdinal) {}
 
 // Ensure that ChromeAppSorting is able to properly initialize off a set
 // of old page and app launch indices and properly convert them.
 class ChromeAppSortingInitialize : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingInitialize() {}
+  ChromeAppSortingInitialize() : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingInitialize() {}
 
   virtual void Initialize() OVERRIDE {
     // A preference determining the order of which the apps appear on the NTP.
     const char kPrefAppLaunchIndexDeprecated[] = "app_launcher_index";
     // A preference determining the page on which an app appears in the NTP.
     const char kPrefPageIndexDeprecated[] = "page_index";
 
     // Setup the deprecated preferences.
     ExtensionScopedPrefs* scoped_prefs =
@@ skipping 47 matching lines @@
     EXPECT_TRUE(first_ordinal.LessThan(
         app_sorting->GetPageOrdinal(extension3()->id())));
   }
 };
 TEST_F(ChromeAppSortingInitialize, ChromeAppSortingInitialize) {}
 
 // Make sure that initialization still works when no extensions are present
 // (i.e. make sure that the web store icon is still loaded into the map).
 class ChromeAppSortingInitializeWithNoApps : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingInitializeWithNoApps() {}
+  ChromeAppSortingInitializeWithNoApps() : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingInitializeWithNoApps() {}
 
   virtual void Initialize() OVERRIDE {
     AppSorting* app_sorting = prefs()->app_sorting();
 
     // Make sure that the web store has valid ordinals.
     syncer::StringOrdinal initial_ordinal =
         syncer::StringOrdinal::CreateInitialOrdinal();
     app_sorting->SetPageOrdinal(extension_misc::kWebStoreAppId,
                                 initial_ordinal);
@@ skipping 27 matching lines @@
 TEST_F(ChromeAppSortingInitializeWithNoApps,
        ChromeAppSortingInitializeWithNoApps) {}
 
 // Tests the application index to ordinal migration code for values that
 // shouldn't be converted. This should be removed when the migrate code
 // is taken out.
 // http://crbug.com/107376
 class ChromeAppSortingMigrateAppIndexInvalid
     : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingMigrateAppIndexInvalid() {}
+  ChromeAppSortingMigrateAppIndexInvalid() : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingMigrateAppIndexInvalid() {}
 
   virtual void Initialize() OVERRIDE {
     // A preference determining the order of which the apps appear on the NTP.
     const char kPrefAppLaunchIndexDeprecated[] = "app_launcher_index";
     // A preference determining the page on which an app appears in the NTP.
     const char kPrefPageIndexDeprecated[] = "page_index";
 
     // Setup the deprecated preference.
     ExtensionScopedPrefs* scoped_prefs =
@@ skipping 15 matching lines @@
     EXPECT_FALSE(prefs()->app_sorting()->GetAppLaunchOrdinal(
         extension1()->id()).IsValid());
   }
 };
 TEST_F(ChromeAppSortingMigrateAppIndexInvalid,
        ChromeAppSortingMigrateAppIndexInvalid) {}
 
 class ChromeAppSortingFixNTPCollisionsAllCollide
     : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingFixNTPCollisionsAllCollide() {}
+  ChromeAppSortingFixNTPCollisionsAllCollide()
+      : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingFixNTPCollisionsAllCollide() {}
 
   virtual void Initialize() OVERRIDE {
     repeated_ordinal_ = syncer::StringOrdinal::CreateInitialOrdinal();
 
     AppSorting* app_sorting = prefs()->app_sorting();
 
     app_sorting->SetAppLaunchOrdinal(extension1()->id(),
                                      repeated_ordinal_);
     app_sorting->SetPageOrdinal(extension1()->id(), repeated_ordinal_);
@@ skipping 35 matching lines @@
 
  private:
   syncer::StringOrdinal repeated_ordinal_;
 };
 TEST_F(ChromeAppSortingFixNTPCollisionsAllCollide,
        ChromeAppSortingFixNTPCollisionsAllCollide) {}
 
 class ChromeAppSortingFixNTPCollisionsSomeCollideAtStart
     : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingFixNTPCollisionsSomeCollideAtStart() {}
+  ChromeAppSortingFixNTPCollisionsSomeCollideAtStart()
+      : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingFixNTPCollisionsSomeCollideAtStart() {}
 
   virtual void Initialize() OVERRIDE {
     first_ordinal_ = syncer::StringOrdinal::CreateInitialOrdinal();
     syncer::StringOrdinal second_ordinal = first_ordinal_.CreateAfter();
 
     AppSorting* app_sorting = prefs()->app_sorting();
 
     // Have the first two extension in the same position, with a third
     // (non-colliding) extension after.
@@ skipping 37 matching lines @@
 
  private:
   syncer::StringOrdinal first_ordinal_;
 };
 TEST_F(ChromeAppSortingFixNTPCollisionsSomeCollideAtStart,
        ChromeAppSortingFixNTPCollisionsSomeCollideAtStart) {}
 
 class ChromeAppSortingFixNTPCollisionsSomeCollideAtEnd
     : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingFixNTPCollisionsSomeCollideAtEnd() {}
+  ChromeAppSortingFixNTPCollisionsSomeCollideAtEnd()
+      : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingFixNTPCollisionsSomeCollideAtEnd() {}
 
   virtual void Initialize() OVERRIDE {
     first_ordinal_ = syncer::StringOrdinal::CreateInitialOrdinal();
     syncer::StringOrdinal second_ordinal = first_ordinal_.CreateAfter();
 
     AppSorting* app_sorting = prefs()->app_sorting();
 
     // Have the first extension in a non-colliding position, followed by two
     // two extension in the same position.
@@ skipping 37 matching lines @@
 
  private:
   syncer::StringOrdinal first_ordinal_;
 };
 TEST_F(ChromeAppSortingFixNTPCollisionsSomeCollideAtEnd,
        ChromeAppSortingFixNTPCollisionsSomeCollideAtEnd) {}
 
 class ChromeAppSortingFixNTPCollisionsTwoCollisions
     : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingFixNTPCollisionsTwoCollisions() {}
+  ChromeAppSortingFixNTPCollisionsTwoCollisions()
+      : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingFixNTPCollisionsTwoCollisions() {}
 
   virtual void Initialize() OVERRIDE {
     first_ordinal_ = syncer::StringOrdinal::CreateInitialOrdinal();
     syncer::StringOrdinal second_ordinal = first_ordinal_.CreateAfter();
 
     AppSorting* app_sorting = prefs()->app_sorting();
 
     // Have two extensions colliding, followed by two more colliding extensions.
     app_sorting->SetAppLaunchOrdinal(extension1()->id(), first_ordinal_);
@@ skipping 47 matching lines @@
 
  private:
   syncer::StringOrdinal first_ordinal_;
 };
 TEST_F(ChromeAppSortingFixNTPCollisionsTwoCollisions,
        ChromeAppSortingFixNTPCollisionsTwoCollisions) {}
 
 class ChromeAppSortingEnsureValidOrdinals
     : public PrefsPrepopulatedTestBase {
  public :
-  ChromeAppSortingEnsureValidOrdinals() {}
+  ChromeAppSortingEnsureValidOrdinals() : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingEnsureValidOrdinals() {}
 
   virtual void Initialize() OVERRIDE {}
   virtual void Verify() OVERRIDE {
     AppSorting* app_sorting = prefs()->app_sorting();
 
     // Give ext1 invalid ordinals and then check that EnsureValidOrdinals fixes
     // them.
     app_sorting->SetAppLaunchOrdinal(extension1()->id(),
                                      syncer::StringOrdinal());
     app_sorting->SetPageOrdinal(extension1()->id(), syncer::StringOrdinal());
 
     app_sorting->EnsureValidOrdinals(extension1()->id(),
                                      syncer::StringOrdinal());
 
     EXPECT_TRUE(app_sorting->GetAppLaunchOrdinal(extension1()->id()).IsValid());
     EXPECT_TRUE(app_sorting->GetPageOrdinal(extension1()->id()).IsValid());
   }
 };
 TEST_F(ChromeAppSortingEnsureValidOrdinals,
        ChromeAppSortingEnsureValidOrdinals) {}
 
 class ChromeAppSortingPageOrdinalMapping : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingPageOrdinalMapping() {}
+  ChromeAppSortingPageOrdinalMapping() : PrefsPrepopulatedTestBase(NULL) {}
   virtual ~ChromeAppSortingPageOrdinalMapping() {}
 
   virtual void Initialize() OVERRIDE {}
   virtual void Verify() OVERRIDE {
     std::string ext_1 = "ext_1";
     std::string ext_2 = "ext_2";
 
     ChromeAppSorting* app_sorting =
         static_cast<ChromeAppSorting*>(prefs()->app_sorting());
     syncer::StringOrdinal first_ordinal =
@@ skipping 35 matching lines @@
 
     it = app_sorting->ntp_ordinal_map_[first_ordinal].find(first_ordinal);
     EXPECT_EQ(ext_2, it->second);
   }
 };
 TEST_F(ChromeAppSortingPageOrdinalMapping,
        ChromeAppSortingPageOrdinalMapping) {}
 
 class ChromeAppSortingPreinstalledAppsBase : public PrefsPrepopulatedTestBase {
  public:
-  ChromeAppSortingPreinstalledAppsBase() {
+  ChromeAppSortingPreinstalledAppsBase() : PrefsPrepopulatedTestBase(NULL) {
     DictionaryValue simple_dict;
     simple_dict.SetString(keys::kVersion, "1.0.0.0");
     simple_dict.SetString(keys::kName, "unused");
     simple_dict.SetString(keys::kApp, "true");
     simple_dict.SetString(keys::kLaunchLocalPath, "fake.html");
 
     std::string error;
     app1_scoped_ = Extension::Create(
         prefs_.temp_dir().AppendASCII("app1_"), Manifest::EXTERNAL_PREF,
         simple_dict, Extension::NO_FLAGS, &error);
@@ skipping 317 matching lines @@
   }
 
  private:
   scoped_refptr<Extension> other_app_;
   scoped_refptr<Extension> yet_another_app_;
 };
 TEST_F(ChromeAppSortingDefaultOrdinalNoCollision,
        ChromeAppSortingDefaultOrdinalNoCollision) {}
 
 }  // namespace extensions