Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1086423003: Make test unthreaded so other tests don't interfere with heap size (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make test unthreaded so other tests don't interfere with heap size R=hpayer@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a0e2dd23cea916eddc9c946f30966e73b217a4f5 Cr-Commit-Position: refs/heads/master@{#27890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-16 14:40:05 UTC) #1
Yang
On 2015/04/16 14:40:05, Erik Corry Chromium.org wrote: Lgtm
5 years, 8 months ago (2015-04-16 14:42:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086423003/1
5 years, 8 months ago (2015-04-16 14:43:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 14:44:35 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0e2dd23cea916eddc9c946f30966e73b217a4f5 Cr-Commit-Position: refs/heads/master@{#27890}
5 years, 8 months ago (2015-04-16 14:44:48 UTC) #6
titzer
5 years, 8 months ago (2015-04-17 09:59:57 UTC) #7
Message was sent while issue was closed.
On 2015/04/16 14:40:05, Erik Corry Chromium.org wrote:

What's the point of this change? Does it somehow depend on the heap size being
stable?

IMO this change only reduces test coverage. It would be better to copy the test
and run it in both threaded and unthreaded modes.

Powered by Google App Engine
This is Rietveld 408576698