Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1086403002: Don't crash when reporting an access check failure for a detached global proxy (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't crash when reporting an access check failure for a detached global proxy BUG=chromium:475884 LOG=y R=verwaest@chromium.org Committed: https://crrev.com/6b59e1f1556a524901aeaa75dc153df21f13f48c Cr-Commit-Position: refs/heads/master@{#27899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M src/isolate.cc View 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Jakob Kummerow
PTAL.
5 years, 8 months ago (2015-04-16 13:50:25 UTC) #1
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-16 16:55:26 UTC) #2
Toon Verwaest
Thanks for fixing!
5 years, 8 months ago (2015-04-16 16:55:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086403002/1
5 years, 8 months ago (2015-04-16 16:56:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 17:46:52 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:47:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b59e1f1556a524901aeaa75dc153df21f13f48c
Cr-Commit-Position: refs/heads/master@{#27899}

Powered by Google App Engine
This is Rietveld 408576698