Issue 1086393004: Yet more ASAN fixes.

Issue 1086393004: Yet more ASAN fixes. (Closed)

Created:
5 years, 8 months ago by Stephen White

Modified:
5 years, 8 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Yet more ASAN fixes. More nullptr checks for factories I have added. Other checks more Yoda-like I have made. (Skia style this is.) BUG=skia: Committed: https://skia.googlesource.com/skia/+/c8e934007a48465e584cdeed9ef02077d3cd5451

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -2 lines)			Patch
M	tests/ImageFilterTest.cpp	View	4 chunks	+12 lines, -0 lines	0 comments	Download
M	tests/SurfaceTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/TessellatingPathRendererTests.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (4 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086393004/1

5 years, 8 months ago (2015-04-21 14:14:27 UTC) #5

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 8 months ago (2015-04-21 14:19:30 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086393004/1

5 years, 8 months ago (2015-04-21 14:20:29 UTC) #9

commit-bot: I haz the power

5 years, 8 months ago (2015-04-21 14:20:43 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c8e934007a48465e584cdeed9ef02077d3cd5451