Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: base/process/process.h

Issue 1086363003: Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed argument passing with nullptr where exit_code was not used.Put proper comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/test/test_metro_viewer_process_host.cc ('k') | base/process/process_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/process.h
diff --git a/base/process/process.h b/base/process/process.h
index 808baeb1fc6ebdf7a9603b7b9b8d070b37694cdd..650b5e669be92c7261dd9464cff8190f67a36ba1 100644
--- a/base/process/process.h
+++ b/base/process/process.h
@@ -102,9 +102,13 @@ class BASE_EXPORT Process {
// On POSIX, if the process has been signaled then |exit_code| is set to -1.
// On Linux this must be a child process, however on Mac and Windows it can be
// any process.
+ // NOTE: |exit_code| is optional, nullptr can be passed if exit code is not
Lei Zhang 2015/05/06 21:38:00 "if the exit code"
g.mehndiratt 2015/05/21 09:29:52 On 2015/05/06 21:38:00, Lei Zhang wrote: Acknowle
+ // required
Lei Zhang 2015/05/06 21:38:00 Please end the sentence with a period.
g.mehndiratt 2015/05/21 09:29:52 On 2015/05/06 21:38:00, Lei Zhang wrote: Acknowle
bool WaitForExit(int* exit_code);
// Same as WaitForExit() but only waits for up to |timeout|.
+ // NOTE: |exit_code| is optional, nullptr can be passed if exit code is not
+ // required
bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code);
// A process is backgrounded when it's priority is lower than normal.
« no previous file with comments | « ash/test/test_metro_viewer_process_host.cc ('k') | base/process/process_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698