 Chromium Code Reviews
 Chromium Code Reviews Issue 1086363003:
  Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1086363003:
  Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: base/process/process.h | 
| diff --git a/base/process/process.h b/base/process/process.h | 
| index 808baeb1fc6ebdf7a9603b7b9b8d070b37694cdd..296f61252ade189e6050eef391315a18f3d2ea43 100644 | 
| --- a/base/process/process.h | 
| +++ b/base/process/process.h | 
| @@ -101,10 +101,12 @@ class BASE_EXPORT Process { | 
| // Waits for the process to exit. Returns true on success. | 
| // On POSIX, if the process has been signaled then |exit_code| is set to -1. | 
| // On Linux this must be a child process, however on Mac and Windows it can be | 
| - // any process. | 
| + // any process. exit_code is optional if exit_code is not required NULL can be | 
| 
Lei Zhang
2015/05/06 08:05:15
We refer to variables as |variable_name|. See line
 
Lei Zhang
2015/05/06 08:05:15
The grammar here needs some work.
 
g.mehndiratt
2015/05/06 10:52:35
On 2015/05/06 08:05:15, Lei Zhang wrote:
Acknowle
 
g.mehndiratt
2015/05/06 10:52:35
On 2015/05/06 08:05:15, Lei Zhang wrote:
Acknowle
 | 
| + // passed. | 
| bool WaitForExit(int* exit_code); | 
| // Same as WaitForExit() but only waits for up to |timeout|. | 
| + // exit_code is optional if exit_code is not required NULL can be passed. | 
| bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code); | 
| // A process is backgrounded when it's priority is lower than normal. |