Handled nullptr argument in WaitForExit() and WaitForExitWithTimeout() methods.

base/process/process_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/process.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 135 matching lines @@
 
 bool Process::WaitForExitWithTimeout(TimeDelta timeout, int* exit_code) {
   // Limit timeout to INFINITE.
   DWORD timeout_ms = saturated_cast<DWORD>(timeout.InMilliseconds());
   if (::WaitForSingleObject(Handle(), timeout_ms) != WAIT_OBJECT_0)
     return false;
 
   DWORD temp_code;  // Don't clobber out-parameters in case of failure.
   if (!::GetExitCodeProcess(Handle(), &temp_code))
     return false;
-
-  *exit_code = temp_code;
+  if (exit_code)

[Lei Zhang, 2015/05/27 06:42:49]

Can you add a blank line above the if statement?

[g.mehndiratt, 2015/05/27 07:28:35]

On 2015/05/27 06:42:49, Lei Zhang wrote:

Acknowledged.

+    *exit_code = temp_code;
   return true;
 }
 
 bool Process::IsProcessBackgrounded() const {
   DCHECK(IsValid());
   DWORD priority = GetPriority();
   if (priority == 0)
     return false;  // Failure case.
   return ((priority == BELOW_NORMAL_PRIORITY_CLASS) ||
           (priority == IDLE_PRIORITY_CLASS));
@@ skipping 28 matching lines @@
 
   return (::SetPriorityClass(Handle(), priority) != 0);
 }
 
 int Process::GetPriority() const {
   DCHECK(IsValid());
   return ::GetPriorityClass(Handle());
 }
 
 }  // namespace base