Serializer: collect and output memory statistics.

Serializer: collect and output memory statistics.

R=jkummerow@chromium.org

Committed: https://crrev.com/a2baf44bf6e913e308ff5dad70c777004bb037cb
Cr-Commit-Position: refs/heads/master@{#27887}

[Yang, 2015-04-16 12:14:12]

Example output:

PartialSerializer:
  Spaces:
       NEW_SPACE       OLD_SPACE      CODE_SPACE       MAP_SPACE        LO_SPACE
              24          183376               0           21648               0
  Instance types:
       246 MAP_TYPE
       479 PROPERTY_CELL_TYPE
        98 FOREIGN_TYPE
        49 EXECUTABLE_ACCESSOR_INFO_TYPE
        88 ACCESSOR_PAIR_TYPE
       566 FIXED_ARRAY_TYPE
        84 WEAK_CELL_TYPE
         3 JS_VALUE_TYPE
         1 JS_DATE_TYPE
        71 JS_OBJECT_TYPE
         1 JS_GLOBAL_OBJECT_TYPE
         1 JS_BUILTINS_OBJECT_TYPE
       206 JS_ARRAY_TYPE
         1 JS_MAP_TYPE
         1 JS_REGEXP_TYPE
       873 JS_FUNCTION_TYPE

StartupSerializer:
  Spaces:
       NEW_SPACE       OLD_SPACE      CODE_SPACE       MAP_SPACE        LO_SPACE
               0          637864          180128            9504               0
  Instance types:
        32 ONE_BYTE_STRING_TYPE
        27 EXTERNAL_ONE_BYTE_STRING_TYPE
      3025 ONE_BYTE_INTERNALIZED_STRING_TYPE
        44 SYMBOL_TYPE
       108 MAP_TYPE
       423 CODE_TYPE
        10 ODDBALL_TYPE
         1 CELL_TYPE
        19 HEAP_NUMBER_TYPE
       597 BYTE_ARRAY_TYPE
         1 EXTERNAL_INT8_ARRAY_TYPE
         1 EXTERNAL_UINT8_ARRAY_TYPE
         1 EXTERNAL_INT16_ARRAY_TYPE
         1 EXTERNAL_UINT16_ARRAY_TYPE
         1 EXTERNAL_INT32_ARRAY_TYPE
         1 EXTERNAL_UINT32_ARRAY_TYPE
         1 EXTERNAL_FLOAT32_ARRAY_TYPE
         1 EXTERNAL_FLOAT64_ARRAY_TYPE
         1 EXTERNAL_UINT8_CLAMPED_ARRAY_TYPE
         1 FIXED_INT8_ARRAY_TYPE
         1 FIXED_UINT8_ARRAY_TYPE
         1 FIXED_INT16_ARRAY_TYPE
         1 FIXED_UINT16_ARRAY_TYPE
         1 FIXED_INT32_ARRAY_TYPE
         1 FIXED_UINT32_ARRAY_TYPE
         1 FIXED_FLOAT32_ARRAY_TYPE
         1 FIXED_FLOAT64_ARRAY_TYPE
         1 FIXED_UINT8_CLAMPED_ARRAY_TYPE
         2 ALLOCATION_SITE_TYPE
        26 SCRIPT_TYPE
         1 POLYMORPHIC_CODE_CACHE_TYPE
       630 FIXED_ARRAY_TYPE
         1 CONSTANT_POOL_ARRAY_TYPE
       856 SHARED_FUNCTION_INFO_TYPE
         5 WEAK_CELL_TYPE
         8 JS_OBJECT_TYPE

[Jakob Kummerow, 2015-04-16 12:32:26]

Beautiful, thanks! LGTM with nits.

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:1238: PrintF("  Spaces:\n");
nit: maybe "  Space usage (bytes):\n"?

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:1244: int s = pending_chunk_[space];
s/int/uint32_t/, as pending_chunk_ is a uint32_t (why not a size_t, btw?)

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:1250: PrintF("  Instance types:\n");
nit: maybe "  Instance types (count):\n"?

I can haz memory consumption in bytes per instance type too? Not strictly
necessary, but would be nice.

[Yang, 2015-04-16 13:00:27]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-04-16 13:00:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1086363002/#ps20001
(title: "addressed comments")

[Yang, 2015-04-16 13:00:43]

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:1238: PrintF("  Spaces:\n");
On 2015/04/16 12:32:25, Jakob wrote:
> nit: maybe "  Space usage (bytes):\n"?

Done.

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:1244: int s = pending_chunk_[space];
On 2015/04/16 12:32:25, Jakob wrote:
> s/int/uint32_t/, as pending_chunk_ is a uint32_t (why not a size_t, btw?)

Done.

https://codereview.chromium.org/1086363002/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:1250: PrintF("  Instance types:\n");
On 2015/04/16 12:32:25, Jakob wrote:
> nit: maybe "  Instance types (count):\n"?
> 
> I can haz memory consumption in bytes per instance type too? Not strictly
> necessary, but would be nice.

Wish and you shall receive.

[commit-bot: I haz the power, 2015-04-16 13:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1086363002/20001

[commit-bot: I haz the power, 2015-04-16 13:39:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 13:39:38]

Patchset 2 (id:??) landed as
https://crrev.com/a2baf44bf6e913e308ff5dad70c777004bb037cb
Cr-Commit-Position: refs/heads/master@{#27887}