src/ia32/lithium-codegen-ia32.cc - Issue 1086333002: Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1086333002: Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Just give up if null or undefined. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index a46cd4bfb9e2edb2d8d649a5234927aa6132c9fa..5ecb80a9149d02dfa95b71e4ef83a387452051d1 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -5599,12 +5599,6 @@ void LCodeGen::DoOsrEntry(LOsrEntry* instr) {

void LCodeGen::DoForInPrepareMap(LForInPrepareMap* instr) {

DCHECK(ToRegister(instr->context()).is(esi));

- __ cmp(eax, isolate()->factory()->undefined_value());

- DeoptimizeIf(equal, instr, Deoptimizer::kUndefined);

- __ cmp(eax, isolate()->factory()->null_value());

- DeoptimizeIf(equal, instr, Deoptimizer::kNull);

__ test(eax, Immediate(kSmiTagMask));

DeoptimizeIf(zero, instr, Deoptimizer::kSmi);

« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »