Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1086333002: Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations" (Closed)

Created:
5 years, 8 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations" BUG=chromium:476592 LOG=n Committed: https://crrev.com/8098253562c7585405f435145e7acf74ff0123f8 Cr-Commit-Position: refs/heads/master@{#27898}

Patch Set 1 #

Patch Set 2 : Fix: add support for for-in over undefined/null #

Patch Set 3 : Remove platform-specific checking of null/undefined now that it's fully handled #

Patch Set 4 : Outline the body and ensure we don't finish the IfBuilder on stack overflow #

Patch Set 5 : Just give up if null or undefined. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -65 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 2 chunks +2 lines, -9 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/deoptimizer.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 4 chunks +68 lines, -23 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
A test/mjsunit/for-in-opt.js View 1 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 8 months ago (2015-04-16 14:43:53 UTC) #2
Igor Sheludko
lgtm
5 years, 8 months ago (2015-04-16 16:49:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086333002/80001
5 years, 8 months ago (2015-04-16 16:56:02 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-16 17:32:12 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:32:25 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8098253562c7585405f435145e7acf74ff0123f8
Cr-Commit-Position: refs/heads/master@{#27898}

Powered by Google App Engine
This is Rietveld 408576698