Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 108633003: HLoadNamedField for Smis optimized for x64 (Closed)

Created:
7 years ago by Igor Sheludko
Modified:
7 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

HLoadNamedField for Smis optimized for x64 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18283

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/hydrogen-instructions.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +9 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Igor Sheludko
7 years ago (2013-12-06 18:05:26 UTC) #1
Toon Verwaest
lgtm with nit. https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64.cc#newcode2851 src/x64/lithium-codegen-x64.cc:2851: offset += kPointerSize / 2; If ...
7 years ago (2013-12-09 13:49:44 UTC) #2
Igor Sheludko
https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64.cc#newcode2851 src/x64/lithium-codegen-x64.cc:2851: offset += kPointerSize / 2; On 2013/12/09 13:49:44, Toon ...
7 years ago (2013-12-09 16:10:35 UTC) #3
Igor Sheludko
Committed patchset #1 manually as r18283 (presubmit successful).
7 years ago (2013-12-09 16:52:05 UTC) #4
titzer
7 years ago (2013-12-09 17:38:32 UTC) #5
Message was sent while issue was closed.
On 2013/12/09 16:52:05, Igor Sheludko wrote:
> Committed patchset #1 manually as r18283 (presubmit successful).

Would have preferred that you didn't land this one yet, but I'll leave it in for
now.

Powered by Google App Engine
This is Rietveld 408576698