HLoadNamedField for Smis optimized for x64

HLoadNamedField for Smis optimized for x64

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18283

[Toon Verwaest, 2013-12-09 13:49:44]

lgtm with nit.

https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:2851: offset += kPointerSize / 2;
If there's a kSmiTagSize, please use that instead.

[Igor Sheludko, 2013-12-09 16:10:35]

https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/108633003/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:2851: offset += kPointerSize / 2;
On 2013/12/09 13:49:44, Toon Verwaest wrote:
> If there's a kSmiTagSize, please use that instead.

There's no such constant. I'll add static assert instead which will serve both
as a check and as a notice that the code below depends on smi's layout:
STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32);

[Igor Sheludko, 2013-12-09 16:52:05]

Committed patchset #1 manually as r18283 (presubmit successful).

[titzer, 2013-12-09 17:38:32]

On 2013/12/09 16:52:05, Igor Sheludko wrote:
> Committed patchset #1 manually as r18283 (presubmit successful).

Would have preferred that you didn't land this one yet, but I'll leave it in for
now.