Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1086303002: [turbofan] Typed lowering requires typed nodes. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Typed lowering requires typed nodes. There's no point in checking whether a node is typed in JSTypedLowering. R=jarin@chromium.org Committed: https://crrev.com/0e703bd34c565495ea10964d59db73130323de23 Cr-Commit-Position: refs/heads/master@{#27863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-16 06:05:22 UTC) #1
Benedikt Meurer
Hey Jaro, Trivial cleanup; typed lowering only runs as part of the typed pipeline, so ...
5 years, 8 months ago (2015-04-16 06:06:10 UTC) #2
Jarin
lgtm
5 years, 8 months ago (2015-04-16 06:27:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086303002/1
5 years, 8 months ago (2015-04-16 06:38:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 06:39:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 06:40:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e703bd34c565495ea10964d59db73130323de23
Cr-Commit-Position: refs/heads/master@{#27863}

Powered by Google App Engine
This is Rietveld 408576698