content/browser/browser_plugin/browser_plugin_guest.cc - Issue 1086283002: Track frame openers in FrameTreeNodes instead of WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 1086283002: Track frame openers in FrameTreeNodes instead of WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Second round of feedback Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index f438805a65f29dc497c4315b34437bc785a4bd8a..f01c9f11abe66b3d2d38ca73fccbd46e1be97531 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -320,7 +320,7 @@ BrowserPluginGuest* BrowserPluginGuest::Create(

WebContentsImpl* web_contents,

BrowserPluginGuestDelegate* delegate) {

return new BrowserPluginGuest(

- web_contents->opener() != nullptr, web_contents, delegate);

+ web_contents->HasOpener(), web_contents, delegate);

}

// static

« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | content/browser/frame_host/frame_tree_browsertest.cc » ('j') | no next file with comments »