android_webview/browser/aw_content_browser_client.h - Issue 1086283002: Track frame openers in FrameTreeNodes instead of WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_content_browser_client.h

Issue 1086283002: Track frame openers in FrameTreeNodes instead of WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Second round of feedback Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_content_browser_client.h

diff --git a/android_webview/browser/aw_content_browser_client.h b/android_webview/browser/aw_content_browser_client.h

index 6d8852daf43e07bb5a0edfdc7227523ccee6930b..2f0e47213f529b1b79c24a65721f5834513cc7d5 100644

--- a/android_webview/browser/aw_content_browser_client.h

+++ b/android_webview/browser/aw_content_browser_client.h

@@ -117,7 +117,8 @@ class AwContentBrowserClient : public content::ContentBrowserClient {

bool opener_suppressed,

content::ResourceContext* context,

int render_process_id,

- int opener_id,

+ int opener_render_view_id,

+ int opener_render_frame_id,

bool* no_javascript_access) override;

void ResourceDispatcherHostCreated() override;

net::NetLog* GetNetLog() override;

« no previous file with comments | « no previous file | android_webview/browser/aw_content_browser_client.cc » ('j') | no next file with comments »