Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: content/public/browser/web_contents.h

Issue 1086283002: Track frame openers in FrameTreeNodes instead of WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Second round of feedback Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 ~CreateParams(); 89 ~CreateParams();
90 CreateParams(BrowserContext* context, SiteInstance* site); 90 CreateParams(BrowserContext* context, SiteInstance* site);
91 91
92 BrowserContext* browser_context; 92 BrowserContext* browser_context;
93 93
94 // Specifying a SiteInstance here is optional. It can be set to avoid an 94 // Specifying a SiteInstance here is optional. It can be set to avoid an
95 // extra process swap if the first navigation is expected to require a 95 // extra process swap if the first navigation is expected to require a
96 // privileged process. 96 // privileged process.
97 SiteInstance* site_instance; 97 SiteInstance* site_instance;
98 98
99 // The opener WebContents is the WebContents that initiated this request, 99 // The process id of the frame initiating the open.
100 // if any. 100 int opener_render_process_id;
101 WebContents* opener; 101
102 // The routing id of the frame initiating the open.
103 int opener_render_frame_id;
102 104
103 // If the opener is suppressed, then the new WebContents doesn't hold a 105 // If the opener is suppressed, then the new WebContents doesn't hold a
104 // reference to its opener. 106 // reference to its opener.
105 bool opener_suppressed; 107 bool opener_suppressed;
106 108
107 // Indicates whether this WebContents was created with a window.opener. 109 // Indicates whether this WebContents was created with a window.opener.
108 // This is used when determining whether the WebContents is allowed to be 110 // This is used when determining whether the WebContents is allowed to be
109 // closed via window.close(). This may be true even with a null |opener| 111 // closed via window.close(). This may be true even with a null |opener|
110 // (e.g., for blocked popups). 112 // (e.g., for blocked popups).
111 bool created_with_opener; 113 bool created_with_opener;
(...skipping 555 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 669
668 private: 670 private:
669 // This interface should only be implemented inside content. 671 // This interface should only be implemented inside content.
670 friend class WebContentsImpl; 672 friend class WebContentsImpl;
671 WebContents() {} 673 WebContents() {}
672 }; 674 };
673 675
674 } // namespace content 676 } // namespace content
675 677
676 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 678 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW
« no previous file with comments | « content/public/browser/content_browser_client.cc ('k') | content/public/browser/web_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698