Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Side by Side Diff: android_webview/browser/aw_content_browser_client.cc

Issue 1086283002: Track frame openers in FrameTreeNodes instead of WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Second round of feedback Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/aw_content_browser_client.h" 5 #include "android_webview/browser/aw_content_browser_client.h"
6 6
7 #include "android_webview/browser/aw_browser_context.h" 7 #include "android_webview/browser/aw_browser_context.h"
8 #include "android_webview/browser/aw_browser_main_parts.h" 8 #include "android_webview/browser/aw_browser_main_parts.h"
9 #include "android_webview/browser/aw_contents_client_bridge_base.h" 9 #include "android_webview/browser/aw_contents_client_bridge_base.h"
10 #include "android_webview/browser/aw_contents_io_thread_client.h" 10 #include "android_webview/browser/aw_contents_io_thread_client.h"
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 const GURL& source_origin, 375 const GURL& source_origin,
376 WindowContainerType container_type, 376 WindowContainerType container_type,
377 const GURL& target_url, 377 const GURL& target_url,
378 const content::Referrer& referrer, 378 const content::Referrer& referrer,
379 WindowOpenDisposition disposition, 379 WindowOpenDisposition disposition,
380 const blink::WebWindowFeatures& features, 380 const blink::WebWindowFeatures& features,
381 bool user_gesture, 381 bool user_gesture,
382 bool opener_suppressed, 382 bool opener_suppressed,
383 content::ResourceContext* context, 383 content::ResourceContext* context,
384 int render_process_id, 384 int render_process_id,
385 int opener_id, 385 int opener_render_view_id,
386 int opener_render_frame_id,
386 bool* no_javascript_access) { 387 bool* no_javascript_access) {
387 // We unconditionally allow popup windows at this stage and will give 388 // We unconditionally allow popup windows at this stage and will give
388 // the embedder the opporunity to handle displaying of the popup in 389 // the embedder the opporunity to handle displaying of the popup in
389 // WebContentsDelegate::AddContents (via the 390 // WebContentsDelegate::AddContents (via the
390 // AwContentsClient.onCreateWindow callback). 391 // AwContentsClient.onCreateWindow callback).
391 // Note that if the embedder has blocked support for creating popup 392 // Note that if the embedder has blocked support for creating popup
392 // windows through AwSettings, then we won't get to this point as 393 // windows through AwSettings, then we won't get to this point as
393 // the popup creation will have been blocked at the WebKit level. 394 // the popup creation will have been blocked at the WebKit level.
394 if (no_javascript_access) { 395 if (no_javascript_access) {
395 *no_javascript_access = false; 396 *no_javascript_access = false;
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 467
467 #if defined(VIDEO_HOLE) 468 #if defined(VIDEO_HOLE)
468 content::ExternalVideoSurfaceContainer* 469 content::ExternalVideoSurfaceContainer*
469 AwContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer( 470 AwContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer(
470 content::WebContents* web_contents) { 471 content::WebContents* web_contents) {
471 return native_factory_->CreateExternalVideoSurfaceContainer(web_contents); 472 return native_factory_->CreateExternalVideoSurfaceContainer(web_contents);
472 } 473 }
473 #endif 474 #endif
474 475
475 } // namespace android_webview 476 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698