Track frame openers in FrameTreeNodes instead of WebContents

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 1205 matching lines @@
   render_view_host_->OnTextSurroundingSelectionResponse(
       content, start_offset, end_offset);
 }
 
 void RenderFrameHostImpl::OnDidAccessInitialDocument() {
   delegate_->DidAccessInitialDocument();
 }
 
 void RenderFrameHostImpl::OnDidDisownOpener() {
   // This message is only sent for top-level frames. TODO(avi): when frame tree
   // mirroring works correctly, add a check here to enforce it.

[Charlie Reis, 2015/06/03 20:01:37]

If this is still main-frame only for now, we can probably DCHECK that and
replace Avi's TODO with one to support owner updates on all frames.

[alexmos, 2015/06/05 22:34:31]

Done.

-  delegate_->DidDisownOpener(this);
+
+  // No action is necessary if the opener has already been cleared.
+  if (!frame_tree_node_->opener())
+    return;
+
+  // Clear our opener so that future cross-process navigations don't have an
+  // opener assigned.
+  frame_tree_node_->SetOpener(nullptr);
+
+  // Notify all swapped out RenderViewHosts for this tab.  This is important

[Charlie Reis, 2015/06/03 20:01:37]

I think this comment was stale.  It's notifying all other RenderFrameHosts and
RenderFrameProxies for the frame.

[alexmos, 2015/06/05 22:34:31]

Done.

+  // in case we go back to them, or if another window in those processes tries
+  // to access window.opener.
+  frame_tree_node_->render_manager()->DidDisownOpener(this);
 }
 
 void RenderFrameHostImpl::OnDidChangeName(const std::string& name) {
   frame_tree_node()->SetFrameName(name);
   delegate_->DidChangeName(this, name);
 }
 
 void RenderFrameHostImpl::OnDidAssignPageId(int32 page_id) {
   // Update the RVH's current page ID so that future IPCs from the renderer
   // correspond to the new page.
@@ skipping 833 matching lines @@
   // We may be returning to an existing NavigationEntry that had been granted
   // file access.  If this is a different process, we will need to grant the
   // access again.  The files listed in the page state are validated when they
   // are received from the renderer to prevent abuse.
   if (request_params.page_state.IsValid()) {
     render_view_host_->GrantFileAccessFromPageState(request_params.page_state);
   }
 }
 
 }  // namespace content