Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1086263002: Make store buffer more robust to OOM. (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make store buffer more robust to OOM. R=hpayer@chromium.org BUG= Committed: https://crrev.com/a3f5e04c998232c7f6407a99949adac11fd718bd Cr-Commit-Position: refs/heads/master@{#27876}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unrelated change to deoptimizer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/heap/store-buffer.cc View 3 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-15 22:48:57 UTC) #1
Erik Corry Chromium.org
We used to start the store buffer at 64k for the new pointers and 4k ...
5 years, 8 months ago (2015-04-15 22:54:22 UTC) #2
Hannes Payer (out of office)
lgtm, one nit https://codereview.chromium.org/1086263002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1086263002/diff/1/src/deoptimizer.cc#newcode2811 src/deoptimizer.cc:2811: "Deoptimizer::EnsureCodeForDeoptimizationEntry"); separate cl?
5 years, 8 months ago (2015-04-16 09:31:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086263002/20001
5 years, 8 months ago (2015-04-16 10:09:54 UTC) #6
Erik Corry Chromium.org
https://codereview.chromium.org/1086263002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1086263002/diff/1/src/deoptimizer.cc#newcode2811 src/deoptimizer.cc:2811: "Deoptimizer::EnsureCodeForDeoptimizationEntry"); On 2015/04/16 09:31:50, Hannes Payer wrote: > separate ...
5 years, 8 months ago (2015-04-16 10:18:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 10:39:53 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 10:40:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3f5e04c998232c7f6407a99949adac11fd718bd
Cr-Commit-Position: refs/heads/master@{#27876}

Powered by Google App Engine
This is Rietveld 408576698