Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1086253004: If a code space commit partially succeeds, free the memory (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

If a code space commit partially succeeds, free the memory R=hpayer@chromium.org BUG= Committed: https://crrev.com/71a19439e8e596b93b2647756b3b60ddb2315edf Cr-Commit-Position: refs/heads/master@{#27884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M src/heap/spaces.cc View 1 chunk +21 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-16 09:50:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086253004/1
5 years, 8 months ago (2015-04-16 10:07:27 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2052)
5 years, 8 months ago (2015-04-16 10:11:55 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-16 13:26:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086253004/1
5 years, 8 months ago (2015-04-16 13:26:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 13:28:24 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 13:28:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71a19439e8e596b93b2647756b3b60ddb2315edf
Cr-Commit-Position: refs/heads/master@{#27884}

Powered by Google App Engine
This is Rietveld 408576698