Issue 1086233002: Revert "skyshell: disable cache for now"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1086233002: Revert "skyshell: disable cache for now" (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
Hixie

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "skyshell: disable cache for now" This reverts commit 9b03c575a4e12f80739d1de7d2c6d66a7cdb214a. https://codereview.chromium.org/999253005 I've not seen the stale caching behavior. I think we need to debug that and fix it. Living with out the cache causes very long load times in SkyShell. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d27d79360296a822966cc0f6d46660767c271b78

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java	View		1 chunk	+11 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

eseidel

5 years, 8 months ago (2015-04-15 22:12:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d27d79360296a822966cc0f6d46660767c271b78 (presubmit successful).